[Mesa-dev] [PATCH v2 5/5] i965: Enabled the OES_copy_image extension on Gen 7 GPUs

[Nanley Chery]

On Sun, Feb 03, 2019 at 03:07:36PM +0200, Eleni Maria Stea wrote:
> OES_copy_image extension was disabled on Gen7 due to the lack of support
> for ETC2 images. Enabled it back. (Kenneth Graunke)
> ---
>  src/mesa/drivers/dri/i965/intel_extensions.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c
> index 3a95be58a63..d2e232f3ff1 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -287,14 +287,24 @@ intelInitExtensions(struct gl_context *ctx)
>     }
>  
>     if (devinfo->gen >= 8 || devinfo->is_baytrail) {
> -      /* For now, we only enable OES_copy_image on platforms that support
> -       * ETC2 natively in hardware.  We would need more hacks to support it
> -       * elsewhere. Same with OES_texture_view.
> +      /*

There's a new blank line here.

> +       * For now, we can't enable OES_texture_view on Gen 7 because of
> +       * some piglit failures coming from
> +       * piglit/tests/spec/arb_texture_view/rendering-formats.c that need
> +       * investigation.
>         */

What kind of failures are you seeing? I'd imagine texture views to work
with this version of your series.

> -      ctx->Extensions.OES_copy_image = true;
>        ctx->Extensions.OES_texture_view = true;
>     }
>  
> +   if (devinfo->gen >= 7) {
> +      /*

There's a new blank line here.

-Nanley

> +       * We can safely enable OES_copy_image on Gen 7, since we emulate
> +       * the ETC2 support using the shadow_miptree to store the
> +       * compressed data.
> +       */
> +      ctx->Extensions.OES_copy_image = true;
> +   }
> +
>     if (devinfo->gen >= 8) {
>        ctx->Extensions.ARB_gpu_shader_int64 = true;
>        /* requires ARB_gpu_shader_int64 */
> -- 
> 2.20.1
>