[Mesa-dev] [PATCH 1/6] winsys/amdgpu: don't drop manually added fence dependencies

Marek Olšák maraeo at gmail.com
Wed Feb 6 21:20:43 UTC 2019


From: Marek Olšák <marek.olsak at amd.com>

wow, it's hard to believe that fence and syncobjs dependencies were ignored.

Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
---
 src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index 4bccd3f0d8b..7b18f54cea9 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
+++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
@@ -1204,22 +1204,20 @@ static void amdgpu_add_fence_dependencies_bo_list(struct amdgpu_cs *acs,
    }
 }
 
 /* Since the kernel driver doesn't synchronize execution between different
  * rings automatically, we have to add fence dependencies manually.
  */
 static void amdgpu_add_fence_dependencies_bo_lists(struct amdgpu_cs *acs)
 {
    struct amdgpu_cs_context *cs = acs->csc;
 
-   cs->num_fence_dependencies = 0;
-
    amdgpu_add_fence_dependencies_bo_list(acs, cs->fence, cs->num_real_buffers, cs->real_buffers);
    amdgpu_add_fence_dependencies_bo_list(acs, cs->fence, cs->num_slab_buffers, cs->slab_buffers);
    amdgpu_add_fence_dependencies_bo_list(acs, cs->fence, cs->num_sparse_buffers, cs->sparse_buffers);
 }
 
 static unsigned add_syncobj_to_signal_entry(struct amdgpu_cs_context *cs)
 {
    unsigned idx = cs->num_syncobj_to_signal++;
 
    if (idx >= cs->max_syncobj_to_signal) {
-- 
2.17.1



More information about the mesa-dev mailing list