[Mesa-dev] [PATCH] kmsro: Silence warning if missing

Alyssa Rosenzweig alyssa at rosenzweig.io
Thu Feb 7 02:13:48 UTC 2019


Regardless of whether the build uses kmsro, kmsro is the default driver
descriptor when the static loader is used. Thus, in an edge case where
the static loader is used, no static targets are loaded, and kmsro is
not compiled, a spurious warning is printed. There's no harm in
executing the stub function in this case, but it's not "an error" to not
have kmsro in the build; the driver missing warning should not printed
kmsro.

Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Reported-by: Karol Herbst <kherbst at redhat.com>
---
 src/gallium/auxiliary/target-helpers/drm_helper.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gallium/auxiliary/target-helpers/drm_helper.h b/src/gallium/auxiliary/target-helpers/drm_helper.h
index 1a87c4494d4..85b026b5264 100644
--- a/src/gallium/auxiliary/target-helpers/drm_helper.h
+++ b/src/gallium/auxiliary/target-helpers/drm_helper.h
@@ -100,7 +100,6 @@ pipe_kmsro_create_screen(int fd, const struct pipe_screen_config *config)
 struct pipe_screen *
 pipe_kmsro_create_screen(int fd, const struct pipe_screen_config *config)
 {
-   fprintf(stderr, "kmsro: driver missing\n");
    return NULL;
 }
 
-- 
2.20.1



More information about the mesa-dev mailing list