[Mesa-dev] [PATCH] freedreno: Fix meson build.

Eric Engestrom eric.engestrom at intel.com
Thu Feb 7 14:59:03 UTC 2019


On Wednesday, 2019-02-06 18:36:09 +0000, Vinson Lee wrote:
> ../src/gallium/drivers/freedreno/freedreno_resource.c: In function ‘fd_resource_create_with_modifiers’:
> ../src/gallium/drivers/freedreno/freedreno_resource.c:884:30: error: ‘DRM_FORMAT_MOD_QCOM_COMPRESSED’ undeclared (first use in this function)
>    allow_ubwc = find_modifier(DRM_FORMAT_MOD_QCOM_COMPRESSED, modifiers, count);
>                               ^

That's a weird error... I would've expected the `#include <drm_fourcc.h>`
to fail with a "No such file". If you copied the wrong part of the error
message, can you update that?

Regardless, the patch is correct:
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> 
> Fixes: 1ce5d757d04a ("freedreno: core buffer modifier support")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/gallium/drivers/freedreno/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/freedreno/meson.build b/src/gallium/drivers/freedreno/meson.build
> index 1e3a3037014b..25aa8ecdb455 100644
> --- a/src/gallium/drivers/freedreno/meson.build
> +++ b/src/gallium/drivers/freedreno/meson.build
> @@ -209,7 +209,7 @@ files_libfreedreno = files(
>  )
>  
>  freedreno_includes = [
> -  inc_src, inc_include, inc_gallium, inc_gallium_aux,
> +  inc_src, inc_include, inc_drm_uapi, inc_gallium, inc_gallium_aux,
>    inc_freedreno, include_directories('ir3'),
>  ]
>  
> -- 
> 2.19.1.dropbox.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list