[Mesa-dev] [PATCH] freedreno: Fix meson build.

[Kristian Høgsberg]

On Thu, Feb 7, 2019 at 8:03 AM Daniel Stone <daniel at fooishbar.org> wrote:
>
> On Thu, 7 Feb 2019 at 14:59, Eric Engestrom <eric.engestrom at intel.com> wrote:
> > On Wednesday, 2019-02-06 18:36:09 +0000, Vinson Lee wrote:
> > > ../src/gallium/drivers/freedreno/freedreno_resource.c: In function ‘fd_resource_create_with_modifiers’:
> > > ../src/gallium/drivers/freedreno/freedreno_resource.c:884:30: error: ‘DRM_FORMAT_MOD_QCOM_COMPRESSED’ undeclared (first use in this function)
> > >    allow_ubwc = find_modifier(DRM_FORMAT_MOD_QCOM_COMPRESSED, modifiers, count);
> >
> > That's a weird error... I would've expected the `#include <drm_fourcc.h>`
> > to fail with a "No such file". If you copied the wrong part of the error
> > message, can you update that?
>
> Presumably it just finds an outdated copy of drm_fourcc.h, which
> doesn't have the Qualcomm modifier, from the system include path.

Yes - I recommend not having include/drm-uapi in the include path and
instead include kernel headers as #include "drm-uapi/drm_fourcc.h" to
avoid pulling in system headers.

Kristian

> Cheers,
> Daniel
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev