[Mesa-dev] [PATCH 2/3] intel/fs: Re-order logical surface arguments

Jason Ekstrand jason at jlekstrand.net
Tue Feb 12 06:38:18 UTC 2019


It makes more sense to start at the surface then move on to the address
and then the data.  Also, this is a really good test of whether or not
we got all the places that use the sources by explicit integer number.
---
 src/intel/compiler/brw_eu_defines.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/intel/compiler/brw_eu_defines.h b/src/intel/compiler/brw_eu_defines.h
index 37b85636c08..aefc43bc7d6 100644
--- a/src/intel/compiler/brw_eu_defines.h
+++ b/src/intel/compiler/brw_eu_defines.h
@@ -852,12 +852,12 @@ enum tex_logical_srcs {
 };
 
 enum surface_logical_srcs {
+   /** Surface binding table index */
+   SURFACE_LOGICAL_SRC_SURFACE,
    /** Surface address; could be multi-dimensional for typed opcodes */
    SURFACE_LOGICAL_SRC_ADDRESS,
    /** Data to be written or used in an atomic op */
    SURFACE_LOGICAL_SRC_DATA,
-   /** Surface binding table index */
-   SURFACE_LOGICAL_SRC_SURFACE,
    /** Surface number of dimensions.  Affects the size of ADDRESS */
    SURFACE_LOGICAL_SRC_IMM_DIMS,
    /** Per-opcode immediate argument.  For atomics, this is the atomic opcode */
-- 
2.20.1



More information about the mesa-dev mailing list