[Mesa-dev] [PATCH] meson: egl: correctly manage loader/xmlconfig

[Emil Velikov]

On Thu, 14 Feb 2019 at 15:33, Eric Engestrom <eric.engestrom at intel.com> wrote:
>
> On Thursday, 2019-02-14 11:43:13 +0000, Emil Velikov wrote:
> > From: Emil Velikov <emil.velikov at collabora.com>
> >
> > Earlier commit introduced support for haiku yet did not properly
> > annotate the loader/xmlconfig dependencies.
> >
> > Thus we ended up adding inc_loader for each !haiku platform - see
> > 659910eda01 9a96bf0ecd0 731508b988 cec6cb01e216.
>
> The last hashes two don't exist in the upstream mesa repo.
>
Right - the leading "c" shifted from the 3th to the 4th sha.
Should be c731508b988 ec6cb01e216 - fixed locally.

> >
> > One piece remained though - the wayland platform. Hence the following
> > would fail:
> >
> >  meson -Dgallium-drivers=etnaviv -Ddri-drivers=''\
> >        -Dtools=etnaviv -Dplatforms=wayland -Dglx=disabled \
> >        build/
> >
> > Cc: Alexander von Gluck IV <kallisti5 at unixzen.com>
> > Cc: Dylan Baker <dylan at pnwbakers.com>
> > Cc: Boris Brezillon <boris.brezillon at collabora.com>
> > Reported-by: Boris Brezillon <boris.brezillon at collabora.com>
> > Fixes: 834d221512f ("meson: Add Haiku platform support v4")
> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>
> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
>
Thanks.

> That said, as far as I understand the autotools code, it builds and
> links the loader on haiku; should that be removed? Or should that be
> added in meson?
>
Autotools doesn't do Haiku. It could but there's no interest.

Thanks again!
-Emil