[Mesa-dev] [PATCH] swr: set PIPE_CAP_MAX_VARYINGS correctly

Hota, Alok alok.hota at intel.com
Thu Feb 14 17:25:34 UTC 2019


Thanks for the patch Ilia.
I had updated the utility function in gallium/aux for this pipe cap but not internal to SWR.

Reviewed-by: Alok Hota <alok.hota at intel.com>

-Alok


> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Ilia Mirkin
> Sent: Wednesday, February 13, 2019 9:35 PM
> To: mesa-dev at lists.freedesktop.org
> Cc: 19 . 0 <mesa-stable at lists.freedesktop.org>
> Subject: [Mesa-dev] [PATCH] swr: set PIPE_CAP_MAX_VARYINGS correctly
> 
> Unfortunately swr was missed in the original commit. The number of varyings
> should generally match up to what's reported as the shader caps for
> fragment inputs.
> 
> Fixes: 6010d7b8e8be (gallium: add PIPE_CAP_MAX_VARYINGS)
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Cc: 19.0 <mesa-stable at lists.freedesktop.org>
> ---
>  src/gallium/drivers/swr/swr_screen.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/gallium/drivers/swr/swr_screen.cpp
> b/src/gallium/drivers/swr/swr_screen.cpp
> index 2b4a37a35b1..68e49a5ae2b 100644
> --- a/src/gallium/drivers/swr/swr_screen.cpp
> +++ b/src/gallium/drivers/swr/swr_screen.cpp
> @@ -370,6 +370,8 @@ swr_get_param(struct pipe_screen *screen, enum
> pipe_cap param)
>        return 32;
>     case PIPE_CAP_MAX_SHADER_BUFFER_SIZE:
>        return 1 << 27;
> +   case PIPE_CAP_MAX_VARYINGS:
> +      return 32;
> 
>     case PIPE_CAP_VENDOR_ID:
>        return 0xFFFFFFFF;
> --
> 2.19.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list