[Mesa-dev] [PATCH 3/7] panfrost: Rectify doubleplusungood extended branch

Alyssa Rosenzweig alyssa at rosenzweig.io
Mon Feb 18 04:39:49 UTC 2019


Midgard features "compact branches" and "extended branches", i.e.
corresponds to short jumps and far jumps. The form of the extended
branch was previously incorrect in the ISA headers; this patch corrects
it.

Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
---
 src/gallium/drivers/panfrost/midgard/midgard.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/panfrost/midgard/midgard.h b/src/gallium/drivers/panfrost/midgard/midgard.h
index b6cd38a5cd0..04e195a635d 100644
--- a/src/gallium/drivers/panfrost/midgard/midgard.h
+++ b/src/gallium/drivers/panfrost/midgard/midgard.h
@@ -231,8 +231,7 @@ __attribute__((__packed__))
         midgard_jmp_writeout_op op : 3; /* == branch_cond */
         unsigned dest_tag : 4; /* tag of branch destination */
         unsigned unknown : 2;
-        signed offset : 7;
-        unsigned zero : 16;
+        signed offset : 23;
         unsigned cond : 16;
 }
 midgard_branch_extended;
-- 
2.20.1



More information about the mesa-dev mailing list