[Mesa-dev] [PATCH 2/3] egl/sl: use drmDevice API to enumerate available devices

[Emil Velikov]

On Mon, 18 Feb 2019 at 16:50, Eric Engestrom <eric.engestrom at intel.com> wrote:
>
> On Tuesday, 2019-02-05 15:31:07 +0000, Emil Velikov wrote:
> > From: Emil Velikov <emil.velikov at collabora.com>
> >
> > This provides for a more comprehensive iteration and a more
> > straight-forward codebase, while minimising the platform specifics.
> >
> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> > ---
> >  src/egl/drivers/dri2/platform_surfaceless.c | 73 +++++++++++----------
> >  1 file changed, 37 insertions(+), 36 deletions(-)
> >
> > diff --git a/src/egl/drivers/dri2/platform_surfaceless.c b/src/egl/drivers/dri2/platform_surfaceless.c
> > index d6e48ba11b2..e1151e3585c 100644
> > --- a/src/egl/drivers/dri2/platform_surfaceless.c
> > +++ b/src/egl/drivers/dri2/platform_surfaceless.c
> > @@ -274,55 +274,56 @@ static const __DRIextension *swrast_loader_extensions[] = {
> >  static bool
> >  surfaceless_probe_device(_EGLDisplay *dpy, bool swrast)
> >  {
> > +#define MAX_DRM_DEVICES 32
> >     struct dri2_egl_display *dri2_dpy = dpy->DriverData;
> > -   const int limit = 64;
>
> Any reason to drop the 64 down to 32?
>
Copy/paste from src/loader and platform_android.c. I don't see us
reaching 16 anytime soon, but sure.
Will tweak and send patches for the other instances.

> Other than that, looks good to me:
> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

Thanks
-Emil