[Mesa-dev] [Bug 109739] Mesa build fails when vulkan-overlay-layer option is enabled

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109739

            Bug ID: 109739
           Summary: Mesa build fails when vulkan-overlay-layer option is
                    enabled
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Vulkan/Common
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: shtetldik at gmail.com
                CC: airlied at freedesktop.org, chadversary at chromium.org,
                    daniel at fooishbar.org, jason at jlekstrand.net

I tried building Mesa master on Debian testing, enabling vulkan-overlay-layer,
and it failed because of mismatching includes. I installed glslang-tools
vulkan-validationlayers-dev and enabled the option:

-Dvulkan-overlay-layer=true

I had to modify includes like this, to make it build:

diff --git a/src/vulkan/overlay-layer/overlay.cpp
b/src/vulkan/overlay-layer/overlay.cpp
index f3678198b00..4b8010ba003 100644
--- a/src/vulkan/overlay-layer/overlay.cpp
+++ b/src/vulkan/overlay-layer/overlay.cpp
@@ -25,13 +25,13 @@
 #include <stdlib.h>
 #include <assert.h>

-#include <vk_loader_platform.h>
+#include <vulkan/vk_loader_platform.h>
 #include <vulkan/vulkan.h>
-#include <vk_dispatch_table_helper.h>
+#include <vulkan/vk_dispatch_table_helper.h>
 #include <vulkan/vk_layer.h>
-#include "vk_layer_data.h"
+#include "vulkan/vk_layer_data.h"
 #include "vk_layer_table.h"
-#include "vk_layer_extension_utils.h"
+#include "vulkan/vk_layer_extension_utils.h"

 #include "imgui.h"

diff --git a/src/vulkan/overlay-layer/vk_layer_table.cpp
b/src/vulkan/overlay-layer/vk_layer_table.cpp
index 4a033b9add6..f5865fa3a6f 100644
--- a/src/vulkan/overlay-layer/vk_layer_table.cpp
+++ b/src/vulkan/overlay-layer/vk_layer_table.cpp
@@ -19,7 +19,7 @@
  */
 #include <assert.h>
 #include <unordered_map>
-#include "vk_dispatch_table_helper.h"
+#include "vulkan/vk_dispatch_table_helper.h"
 #include "vulkan/vk_layer.h"
 #include "vk_layer_table.h"
 static device_table_map tableMap;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190222/810976a6/attachment-0001.html>