[Mesa-dev] [PATCH] nir/split_vars: Don't compact vectors unnecissarily

[apinheiro]

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

On 23/2/19 6:14, Jason Ekstrand wrote:
> ---
>   src/compiler/nir/nir_split_vars.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/compiler/nir/nir_split_vars.c b/src/compiler/nir/nir_split_vars.c
> index 244ffd6dcf0..96b6042e6d9 100644
> --- a/src/compiler/nir/nir_split_vars.c
> +++ b/src/compiler/nir/nir_split_vars.c
> @@ -1423,6 +1423,12 @@ shrink_vec_var_access_impl(nir_function_impl *impl,
>                  continue;
>               }
>   
> +            /* If we're not dropping any components, there's no need to
> +             * compact vectors.
> +             */
> +            if (usage->comps_kept == usage->all_comps)
> +               continue;
> +
>               if (intrin->intrinsic == nir_intrinsic_load_deref) {
>                  b.cursor = nir_after_instr(&intrin->instr);
>