[Mesa-dev] [PATCH 1/3] panfrost: Add RGB555, RGB5A1 texture formats

[Ilia Mirkin]

On Sun, Feb 24, 2019 at 1:36 AM Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:
>
> Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
> ---
>  src/gallium/drivers/panfrost/include/panfrost-job.h | 2 ++
>  src/gallium/drivers/panfrost/pan_pretty_print.c     | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h b/src/gallium/drivers/panfrost/include/panfrost-job.h
> index 82b3cfb2a4f..072f0258bea 100644
> --- a/src/gallium/drivers/panfrost/include/panfrost-job.h
> +++ b/src/gallium/drivers/panfrost/include/panfrost-job.h
> @@ -306,6 +306,8 @@ struct mali_channel_swizzle {
>  #define MALI_CHANNEL_FLOAT 7
>
>  enum mali_format {
> +       MALI_RGB555         = MALI_FORMAT_SPECIAL | 0x0,

Just a thought -- RGB565, which is a fairly popular 16-bit color
variant, would fit nicely into the space here, and is probably also
one of the "special" formats. (Slightly surprising there's a separate
RGB555 and RGB5_A1 - normally that's handled by swizzling. Could it be
the difference between where the A1 bit is -- first vs last? Perhaps
that's also why there's a space after each of the RGB10A2 formats --
to also allow A2RGB10.)

Another good candidate for special handling is RGB9_E5 (shared
exponent), and I don't see a Z24 in the list.

Cheers,

  -ilia