[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109532

--- Comment #44 from asimiklit <andrey.simiklit at gmail.com> ---
(In reply to Mark Janes from comment #42)
> i965 CI runs debug builds by default, but for mesa it uses these meson
> configurations:
> 
>   -Dbuildtype=release -Db_ndebug=true
> 
> We must catch assertions in the CI, however debug builds are much slower to
> execute tests.

My tests depends on DEBUG macro:
https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/compiler/glsl/ir_validate.cpp#L1059-1073

So if DEBUG macro is not defined my tests should not call critical
code which leads mesa to crash and should just pass.

Also from 'meson.build':
https://gitlab.freedesktop.org/mesa/mesa/blob/master/meson.build#L742-745
  "# Define DEBUG for debug builds only (debugoptimized is not included on this
one)
   if get_option('buildtype') == 'debug'
     pre_args += '-DDEBUG'
   endif
   "

So as far as I understood DEBUG macro will be defined for '-Dbuildtype=debug' 
configuration only but as you mentioned above the mesa is compiled with
'-Dbuildtype=release'
in this case my tests should just pass without crash.

Does CI use the same configurations for x32 and x64 mesa builds or
maybe x64 uses debug mesa config '-Dbuildtype=debug'?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190226/fb53f069/attachment.html>