[Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

[Dylan Baker]

Quoting Ian Romanick (2019-01-02 12:57:26)
> On 12/19/18 9:25 AM, Dylan Baker wrote:
> > Quoting Jonathan Marek (2018-12-19 08:39:53)
> >> Mainly a copy of nir_lower_bool_to_int32, but with float opcodes.
> >>
> >> Signed-off-by: Jonathan Marek <jonathan at marek.ca>
> >> ---
> >>  src/compiler/Makefile.sources              |   1 +
> >>  src/compiler/nir/meson.build               |   3 +-
> >>  src/compiler/nir/nir.h                     |   1 +
> >>  src/compiler/nir/nir_lower_bool_to_float.c | 165 +++++++++++++++++++++
> >>  4 files changed, 169 insertions(+), 1 deletion(-)
> >>  create mode 100644 src/compiler/nir/nir_lower_bool_to_float.c
> >>
> >> diff --git a/src/compiler/Makefile.sources b/src/compiler/Makefile.sources
> >> index ef47bdb33b..39eaedc658 100644
> >> --- a/src/compiler/Makefile.sources
> >> +++ b/src/compiler/Makefile.sources
> >> @@ -231,6 +231,7 @@ NIR_FILES = \
> >>         nir/nir_lower_atomics_to_ssbo.c \
> >>         nir/nir_lower_bitmap.c \
> >>         nir/nir_lower_bit_size.c \
> >> +       nir/nir_lower_bool_to_float.c \
> >>         nir/nir_lower_bool_to_int32.c \
> >>         nir/nir_lower_clamp_color_outputs.c \
> >>         nir/nir_lower_clip.c \
> >> diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build
> >> index e252f64539..f1016104af 100644
> >> --- a/src/compiler/nir/meson.build
> >> +++ b/src/compiler/nir/meson.build
> >> @@ -114,6 +114,7 @@ files_libnir = files(
> >>    'nir_lower_alpha_test.c',
> >>    'nir_lower_atomics_to_ssbo.c',
> >>    'nir_lower_bitmap.c',
> >> +  'nir_lower_bool_to_float.c',
> >>    'nir_lower_bool_to_int32.c',
> >>    'nir_lower_clamp_color_outputs.c',
> >>    'nir_lower_clip.c',
> >> @@ -248,7 +249,7 @@ if with_tests
> >>        include_directories : [inc_common],
> >>        dependencies : [dep_thread, idep_gtest, idep_nir],
> >>        link_with : libmesa_util,
> >> -    ), 
> >> +    ),
> > 
> > This looks like stray whitespace?
> 
> It's deleting a stray (incorrect?) whitespace.  I'm usually not fond of
> slipping unrelated changes into a commit... but who's going to send a
> 1-line patch that deletes a single space character? :)

Ah, it wasn't clear whether it was removing whitespace or adding it :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190102/64c1ae3f/attachment.sig>