[Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

Timothy Arceri tarceri at itsqueeze.com
Mon Jan 7 23:15:53 UTC 2019


On 8/1/19 2:51 am, Andres Gomez wrote:
> On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote:
>> On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote:
>>> Correct a typo introduced by
>>> 037f68d81e1 ("glsl: apply align layout qualifier rules to block
>>> offsets")
>>>
>>> Cc: Timothy Arceri <tarceri at itsqueeze.com>
>>> Signed-off-by: Andres Gomez <agomez at igalia.com>
>>
>> This should probably have this tag:
>>
>> Fixes: 037f68d81e1 "glsl: apply align layout qualifier rules to block
>>                      offsets"
> 
> Didn't think it was important enough to add the tag which will pull
> into the stable releases ...
> 
> ... it will also be more traceable with it added so, I suppose I will
> do so.

Seems fine to go into stable :)

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

Thanks!

> 
>> With that added:
>>
>> Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> 
> Thanks! ☺
> 


More information about the mesa-dev mailing list