[Mesa-dev] [PATCH 2/2] st/mesa: don't reference pipe_surface locally in PBO code

Marek Olšák maraeo at gmail.com
Tue Jan 8 15:57:33 UTC 2019


From: Marek Olšák <marek.olsak at amd.com>

---
 src/mesa/state_tracker/st_cb_texture.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c
index 45918e425ac..ff4694da9e0 100644
--- a/src/mesa/state_tracker/st_cb_texture.c
+++ b/src/mesa/state_tracker/st_cb_texture.c
@@ -1236,25 +1236,23 @@ try_pbo_upload_common(struct gl_context *ctx,
       pipe_sampler_view_reference(&sampler_view, NULL);
    }
 
    /* Framebuffer_state */
    {
       struct pipe_framebuffer_state fb;
       memset(&fb, 0, sizeof(fb));
       fb.width = surface->width;
       fb.height = surface->height;
       fb.nr_cbufs = 1;
-      pipe_surface_reference(&fb.cbufs[0], surface);
+      fb.cbufs[0] = surface;
 
       cso_set_framebuffer(cso, &fb);
-
-      pipe_surface_reference(&fb.cbufs[0], NULL);
    }
 
    cso_set_viewport_dims(cso, surface->width, surface->height, FALSE);
 
    /* Blend state */
    cso_set_blend(cso, &st->pbo.upload_blend);
 
    /* Depth/stencil/alpha state */
    {
       struct pipe_depth_stencil_alpha_state dsa;
-- 
2.17.1



More information about the mesa-dev mailing list