[Mesa-dev] [PATCH 1/3] radv: remove unnecessary return in GetPhysicalDeviceMemoryProperties2()

andrey simiklit asimiklit.work at gmail.com
Wed Jan 9 12:16:39 UTC 2019


Hello,

Looks like the same fix could be done in the following functions:
radv_GetPhysicalDeviceQueueFamilyProperties
radv_GetPhysicalDeviceQueueFamilyProperties2
just for case if you want to fix all these issues:)

Regards,
Andrii.

On Mon, Jan 7, 2019 at 6:35 PM Samuel Pitoiset <samuel.pitoiset at gmail.com>
wrote:

> This function returns nothing.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 53aed1a15db..39bd47348a9 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -1345,8 +1345,8 @@ void radv_GetPhysicalDeviceMemoryProperties2(
>         VkPhysicalDevice                            physicalDevice,
>         VkPhysicalDeviceMemoryProperties2KHR       *pMemoryProperties)
>  {
> -       return radv_GetPhysicalDeviceMemoryProperties(physicalDevice,
> -
>  &pMemoryProperties->memoryProperties);
> +       radv_GetPhysicalDeviceMemoryProperties(physicalDevice,
> +
> &pMemoryProperties->memoryProperties);
>  }
>
>  VkResult radv_GetMemoryHostPointerPropertiesEXT(
> --
> 2.20.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190109/7fb1ff14/attachment.html>


More information about the mesa-dev mailing list