[Mesa-dev] [PATCH] nir: fix copy-paste error in nir_lower_constant_initializers

Jason Ekstrand jason at jlekstrand.net
Thu Jan 10 16:35:02 UTC 2019


Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Thu, Jan 10, 2019 at 5:57 AM Erik Faye-Lund <erik.faye-lund at collabora.com>
wrote:

> Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
>
> On Thu, 2019-01-10 at 11:23 +0000, Rhys Perry wrote:
> > Fixes: 393b59e0772e7bf0426bdf61c740752c4e09dde1
> >     ('nir: Rework nir_lower_constant_initializers() to handle
> > functions')
> > ---
> >  src/compiler/nir/nir_lower_constant_initializers.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/compiler/nir/nir_lower_constant_initializers.c
> > b/src/compiler/nir/nir_lower_constant_initializers.c
> > index cbee59b1f30..959d1eabfca 100644
> > --- a/src/compiler/nir/nir_lower_constant_initializers.c
> > +++ b/src/compiler/nir/nir_lower_constant_initializers.c
> > @@ -104,10 +104,10 @@ nir_lower_constant_initializers(nir_shader
> > *shader, nir_variable_mode modes)
> >           impl_progress |= lower_const_initializer(&builder, &shader-
> > >outputs);
> >
> >        if ((modes & nir_var_private) && function->is_entrypoint)
> > -         impl_progress |= lower_const_initializer(&builder, &shader-
> > >outputs);
> > +         impl_progress |= lower_const_initializer(&builder, &shader-
> > >globals);
> >
> >        if ((modes & nir_var_system_value) && function->is_entrypoint)
> > -         impl_progress |= lower_const_initializer(&builder, &shader-
> > >outputs);
> > +         impl_progress |= lower_const_initializer(&builder, &shader-
> > >system_values);
> >
> >        if (modes & nir_var_function)
> >           impl_progress |= lower_const_initializer(&builder,
> > &function->impl->locals);
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190110/dd45c2ec/attachment.html>


More information about the mesa-dev mailing list