[Mesa-dev] [PATCH] anv/pipeline_cache: fix incorrect guards for NIR cache

Lionel Landwerlin lionel.g.landwerlin at intel.com
Fri Jan 11 11:43:32 UTC 2019


On 11/01/2019 11:41, Iago Toral wrote:
> On Fri, 2019-01-11 at 11:13 +0000, Lionel Landwerlin wrote:
>> On 11/01/2019 10:50, Iago Toral Quiroga wrote:
>>> Fixes: f6aa9f718516 'anv/pipeline_cache: Add support for caching
>>> NIR'
>>> ---
>>>    src/intel/vulkan/anv_pipeline_cache.c | 5 +++--
>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> Or maybe just check cache->cache instead, which I guess was the
>>> original
>>> intention, but I kind of prefer having all fields initialized.
>>
>> While looking at this patch, I noticed that we're not freeing
>> nir_cache
>> in anv_pipeline_cache_finish.
> Right, I'll send a separate patch for that.
>
> Iago
>

Thanks a lot :)



More information about the mesa-dev mailing list