[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

Eric Engestrom eric.engestrom at intel.com
Fri Jan 11 14:56:43 UTC 2019


On Friday, 2019-01-11 16:42:25 +0200, Andres Gomez wrote:
> "--summary" will also print extended header information such as
> creations, renames and mode changes.
> 
> Let's just use "-s", which suppresses the diff output.
> 
> Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline printing")
> Cc: Juan A. Suarez <jasuarez at igalia.com>
> Cc: Eric Engestrom <eric.engestrom at intel.com>
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Signed-off-by: Andres Gomez <agomez at igalia.com>
> ---
>  bin/get-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index 3099fc69413..d71ff4a708a 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -143,7 +143,7 @@ do
>  	esac
>  
>  	printf "[ %8s ] " "$tag"
> -	git --no-pager show --summary --oneline $sha
> +	git --no-pager show -s --oneline $sha

Small preference for the explicit `--no-patch` instead of `-s`, but:
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

>  done
>  
>  rm -f already_picked
> -- 
> 2.18.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list