[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

Eric Engestrom eric.engestrom at intel.com
Fri Jan 11 15:06:02 UTC 2019


On Friday, 2019-01-11 16:43:27 +0200, Andres Gomez wrote:
> "&>" is bash specific.
> 
> Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid sha")
> Cc: Juan A. Suarez <jasuarez at igalia.com>
> Cc: Eric Engestrom <eric.engestrom at intel.com>
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Signed-off-by: Andres Gomez <agomez at igalia.com>

Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> ---
>  bin/get-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index 79b7a295ea6..3099fc69413 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -44,7 +44,7 @@ is_sha_nomination()
>  		# Treat only the current line
>  		id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d : -f 2`
>  		fixes_count=$(($fixes_count-1))
> -		if ! git show $id &>/dev/null; then
> +		if ! git show $id >/dev/null 2>&1; then
>  			echo WARNING: Commit $1 lists invalid sha $id
>  		fi
>  	done
> -- 
> 2.18.0
> 


More information about the mesa-dev mailing list