[Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

[Matt Turner]

On Fri, Jan 11, 2019 at 9:11 AM Kenneth Graunke <kenneth at whitecape.org> wrote:
>
> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote:
> > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote:
> > > Those names (nir_var_func_local, nir_var_thread_local, and
> > > nir_var_thread_global) make more sense to me than private/function.
> > >
> > > Another option is `nir_var_local_temp` and `nir_var_shader_temp`,
> > > indicating that they're just temporary variables, and not anything
> > > with special semantics like memory.  shader_temp would pair well with
> > > the existing shader_in/shader_out, since they have the same scope.
> > >
> > > I might also consider adding 'mem' to variables representing memory.
> > >
> > > So that would look like...
> > >
> > >    nir_var_shader_in
> > >    nir_var_shader_out
> > >    nir_var_shader_temp  (formerly local/function)
> > >    nir_var_local_temp   (formerly global/private)
> > >
> >
> > Are those flipped?
>
> Gah!  Sorry.  Yes.
>
>    nir_var_shader_in
>    nir_var_shader_out
>    nir_var_shader_temp  (formerly global/private)
>    nir_var_local_temp   (formerly local/function)
>    nir_var_uniform
>    nir_var_system_value
>    nir_var_mem_ubo      (added mem)
>    nir_var_mem_ssbo     (added mem)
>    nir_var_mem_shared   (added mem)
>    nir_var_mem_global   (the new global memory type being introduced)

That sounds good to me. Thanks for coming up with those names.