[Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

[Jason Ekstrand]

On Fri, Jan 11, 2019 at 1:55 PM Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote:
> > I think I kind of like having "mem" be on external things.  Shared is a
> > little weird there because it never leaves the chip so is it mem or
> shader?
>
> On Intel GPUs, "shared" maps to a concept called "Shared Local Memory".
> So I tend to think of it as memory :)
>
> It's not perfect, though.  While most shader_in/shader_out end up being
> thread-local, shader_out in a TCS is actually shared across threads (and
> pre-dates the shared keyword).
>
> I'm sort of inclined to leave that alone for now unless you think we
> ought to do something about it.
>

If by "leave it alone" you mean leave _mem on there, that's fine with me.
It was more of a philosophical question than an actual request for any sort
of change.


> > > We may also want to rename the nir->globals list, or
> > > nir_lower_global_vars_to_local and nir_opt_global_to_local.  Not sure.
> > >
> >
> > Yes, whatever we do, we should make those lists more consistent.
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190111/8a80a1a4/attachment.html>