[Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

[Roland Scheidegger]

Am 11.01.19 um 23:28 schrieb Ilia Mirkin:
> On Fri, Jan 11, 2019 at 5:12 PM Matt Turner <mattst88 at gmail.com> wrote:
>>
>> From: Gert Wollny <gw.fossdev at gmail.com>
>>
>> Since Meson will eventually be the only build system deprecate autotools
>> now. It can still be used by invoking configure with the flag
>>   --enable-autotools
>>
>> NAKed-by: Ilia Mirkin <imirkin at alum.mit.edu>
> 
> [nouveau]
> 
>> Acked-by: Eric Engestrom <eric.engestrom at intel.com>
>> Acked-by: Kenneth Graunke <kenneth at whitecape.org>
>> Acked-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Acked-by: Jason Ekstrand <jason at jlekstrand.net>
>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> 
> [intel]
> 
>> Acked-by: Rob Clark <robdclark at gmail.com>
> 
> [freedreno]
> 
>> Acked-by: Marek Olšák <marek.olsak at amd.com>
> 
> [radeon]
> 
>> Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> 
> [etnaviv]
> 
>> Reviewed-by: Eric Anholt <eric at anholt.net>
> 
> [vc4]
> 
>> Signed-off-by: Gert Wollny <gw.fossdev at gmail.com>
> 
> [sorry Gert, not sure how to classify you]
> 
> I think the vmware team (which largely maintains llvmpipe and svga) is
> probably worth hearing from -- I believe they've largely stayed out of
> it. But an ack/nack would be good. Also virgl isn't represented, I
> believe. Probably not *required* to hear from these, but perhaps worth
> a poke?

I don't think we actually use autotools anywhere (we use scons)
officially, so I don't think we have any objections to deprecate
autotools. Though at some point we should probably adopt meson too...

Roland

> 
>> ---
>> I think there's support for overriding the sole objection to this patch.
>>
>> To confirm:
>>
>>     (1) The plan is to remove Autotools, perhaps after the 19.0 release
>>
>>     (2) This patch's purpose is to ensure that everyone knows that
>>         Autotools will be going away (think: people who build Mesa as
>>         part of an automated process and wouldn't notice a deprecation
>>         warning unless it requires some action from them)
> 
> If it's being removed _after_ the 19.0 release, does it make sense to
> have a patch like this _in_ the 19.0 release? (Perhaps the answer is
> `yes', but I'd still like to ask the question.)
> 
>>
>>     (3) We expect all reasonable concerns about Meson to be resolved
>>         before Autotools is removed (e.g., reconfiguration problems,
>>         retrieving configuration command line, configuration status
>>         output, etc.)
>>
>>  configure.ac | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index e4d20054d5f..c7473d77eff 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -52,6 +52,19 @@ mingw*)
>>      ;;
>>  esac
>>
>> +AC_ARG_ENABLE(autotools,
>> +   [AS_HELP_STRING([--enable-autotools],
>> +                   [Enable the use of this autotools based build configuration])],
>> +   [enable_autotools=$enableval], [enable_autotools=no])
>> +
>> +if test "x$enable_autotools" != "xyes" ; then
>> +    AC_MSG_ERROR([the autotools build system has been deprecated in favour of
>> +    meson and will be removed eventually. For instructions on how to use meson
>> +    see https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.mesa3d.org%2Fmeson.html&data=02%7C01%7Csroland%40vmware.com%7C6318bcef4bb8448c161808d678142d0c%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636828425410064737&sdata=LPbkdwrhgg2lC%2FNDJl54GbV5DSQtM6YWu16g68IGEME%3D&reserved=0.
>> +    If you still want to use the autotools build, then add --enable-autotools
>> +    to the configure command line.])
>> +fi
>> +
>>  # Support silent build rules, requires at least automake-1.11. Disable
>>  # by either passing --disable-silent-rules to configure or passing V=1
>>  # to make
>> --
>> 2.19.2
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Csroland%40vmware.com%7C6318bcef4bb8448c161808d678142d0c%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636828425410064737&sdata=xuss8y2JSxq4Tlzz4JRppDaP9Kze5r8k8RbLpJnixIo%3D&reserved=0
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Csroland%40vmware.com%7C6318bcef4bb8448c161808d678142d0c%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636828425410064737&sdata=xuss8y2JSxq4Tlzz4JRppDaP9Kze5r8k8RbLpJnixIo%3D&reserved=0
>