[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93551

--- Comment #63 from Thomas Crider <gloriouseggroll at gmail.com> ---
(In reply to Axel Davy from comment #62)
> I believe the generic configuration proposed answers your OOTB concern. Mesa
> packs a default drirc (not visible anymore to the user):
> src/util/00-mesa-defaults.conf
> 
> As you can see there are already radeonsi specific workarounds (and it seems
> my memory was rusty about the syntax).
> The user would never have to use .drirc to set the string.
> 
> I've been contributing to mesa for several years now, and I believe my
> suggestion is more in line with the philosophy of the project and has higher
> chances of being accepted. That said, your proposal may get accepted, you
> can get feedback by posting your patch proposal on the mailing list or
> asking on irc.

I'm aware of the default configuration file. My patch applies the config
modification to it. What I'm trying to say is if you set it as a boolean, you
kill two birds with one stone, as the names need to be changed per driver
anyway. If you take a look at the patch y0u'll see how it's handled. In the
patch, setting the boolean makes dri_context set an envvar with the same name
and value to 1. This then gets picked up by si_get via getenv and the name is
set. All that would need to be done for intel is to copy/paste the si_get code
into intel's intel_context/brw_context and modify it as needed. This would
provide 1 boolean for 3 drivers at the same time for that game, without needing
to add 3 seperate vendor override options in driconf

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190114/c09eaf9e/attachment-0001.html>