[Mesa-dev] [Bug 109405] [BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109405

            Bug ID: 109405
           Summary: [BISECTED] [REGRESSION]
                    KHR-GL45.enhanced_layouts.glsl_contant_immutablity
                    aborts in second execution
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: glsl-compiler
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: agomez at igalia.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org
                CC: t_arceri at yahoo.com.au

After:

--

commit 64b8c86d37ebb1e1d286c69d642d52b7bcf051d3 (danger/master)
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Thu Jan 17 17:16:29 2019 +1100

    glsl: be much more aggressive when skipping shader compilation

    Currently we only add a cache key for a shader once it is linked.
    However games like Team Fortress 2 compile a whole bunch of shaders
    which are never actually linked. These compiled shaders can take
    up a bunch of memory.

    This patch changes things so that we add the key for the shader to
    the cache as soon as it is compiled. This means on a warm cache we
    can avoid the wasted memory from these shaders. Worst case scenario
    is we need to compile the shaders at link time but this can happen
    anyway if the shader has been evicted from the cache.

    Reduces memory use in Team Fortress 2 from 1.3GB -> 770MB on a
    warm cache from start up to the game menu.

    Acked-by: Marek Olšák <marek.olsak at amd.com>

--

The following VK-GL-CTS test is failing in a second execution with the i965
driver, shader cache activated, and the x11_egl target:

--

local at 5207cd755898:~/vk-gl-cts/build/external/openglcts/modules$ ./glcts
--deqp-case="KHR-GL45.enhanced_layouts.glsl_contant_immutablity"                
Writing test log into TestResults.qpa
dEQP Core git-117ce3699c7e2d3d04f1760b25399aedd5dc90fa (0x117ce369) starting..
  target implementation = 'X11 EGL'
ATTENTION: default value of option vblank_mode overridden by environment.

Test case 'KHR-GL45.enhanced_layouts.glsl_contant_immutablity'..
  Pass (Pass)

DONE!

Test run totals:
  Passed:        1/1 (100.0%)
  Failed:        0/1 (0.0%)
  Not supported: 0/1 (0.0%)
  Warnings:      0/1 (0.0%)
local at 5207cd755898:~/vk-gl-cts/build/external/openglcts/modules$ ./glcts
--deqp-case="KHR-GL45.enhanced_layouts.glsl_contant_immutablity"                
Writing test log into TestResults.qpa
dEQP Core git-117ce3699c7e2d3d04f1760b25399aedd5dc90fa (0x117ce369) starting..
  target implementation = 'X11 EGL'
ATTENTION: default value of option vblank_mode overridden by environment.

Test case 'KHR-GL45.enhanced_layouts.glsl_contant_immutablity'..
Segmentation fault (core dumped)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190121/8e308ebc/attachment.html>