[Mesa-dev] [PATCH 3/8] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

[Eleni Maria Stea]

> > +   /**
> > +    * \brief Indicates that we fake the ETC2 compression support
> > +    *
> > +    * GPUs Gen < 8 don't support sampling and rendering of ETC2
> > formats so
> > +    * we need to fake it. This variable is set to true when we
> > fake it.
> > +    */
> > +   bool needs_fake_etc;
> > +  
> 
> Let's make a function to detect needs_fake_etc instead of adding to
> the data structure. That'd be easier to follow.
> 
> -Nanley


Hi Nanley,

I'd like a small clarification here if you don't mind: I wasn't very
sure about this last change you suggest.

The reasons I preferred to extend the data structure instead of adding
a function were:

1- that I need to check if we fake ETC in several different places in
which I don't always have access to the information that helped me
decide if we need to fake the ETC or not, so I found it much easier to
keep this information in the miptree that can be accessed from
everywhere. (That was the main reason).

The other reasons were that:
2- I thought that it would be faster to check the miptree than call a
function.
3- I was hoping that from the name of the variable it won't be
difficult to follow (but I could rename it to something better if you
prefer it).

Could you explain me why you'd like me to replace it? Is there an
advantage I hadn't thought of?

Thank you in advance,
Eleni