[Mesa-dev] [PATCH mesa] configure: EGL requirements only apply if EGL is built

Eric Engestrom eric.engestrom at intel.com
Tue Jan 22 16:04:31 UTC 2019


On Tuesday, 2019-01-22 13:32:15 +0000, Emil Velikov wrote:
> On Mon, 21 Jan 2019 at 19:53, Eric Engestrom <eric.engestrom at intel.com> wrote:
> >
> AFAICT this triggers when egl is explicitly disabled and drm is
> explicitly listed in the with-platforms list.
> Please add the triggering configure line to the commit message.

Yes sorry, that's exactly how I hit this error:
  --disable-{egl,gbm,glx} --with-platform=drm

Added to the commit message.

> 
> 
> > Fixes: 2c4f6ceeb466cb15df34 "configure.ac: Fail if egl x11 platform
> >                              dependencies are not available"
> > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> 
> The above fixes commit caters only for egl-platforms. So I think we'd
> want the one below instead.
> 
> Fixes: 3208fd2e46b ("configure: move platform handling further up")

Fair, I may have gone too far back in time :]

> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks :)


More information about the mesa-dev mailing list