[Mesa-dev] [PATCH] docs: add note about sending merge-requests from forks

[Eric Engestrom]

On Wednesday, 2019-01-23 11:28:14 +0100, Erik Faye-Lund wrote:
> On Wed, 2019-01-23 at 10:08 +0000, Eric Engestrom wrote:
> > On Wednesday, 2019-01-23 10:36:15 +0100, Erik Faye-Lund wrote:
> > > Sending MRs from the main Mesa repository increase clutter in the
> > > repository, and decrease visibility of project-wide branches. So
> > > it's
> > > better if MRs are sent from forks instead.
> > > 
> > > Let's add a note about this, in case its not obvious to everyone.
> > 
> > Yes please, we already have way too many dead branches in the main
> > repo
> > without adding that kind of things to it.
> > 
> > One other thing is that (last time I checked) the scripts propagating
> > the repo to github et al. don't propagate branch deletions, which
> > means
> > the clutter never gets cleaned there.
> > 
> > > Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> > > ---
> > >  docs/submittingpatches.html | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/docs/submittingpatches.html
> > > b/docs/submittingpatches.html
> > > index 736cbd64de8..b5a70523acd 100644
> > > --- a/docs/submittingpatches.html
> > > +++ b/docs/submittingpatches.html
> > > @@ -258,6 +258,8 @@ your email administrator for this.)
> > >        rebased
> > >      <li>Make sure your MR is closed if your patches get pushed
> > > outside
> > >        of GitLab
> > > +    <li>Please send MRs from a personal fork rather than from the
> > > main
> > > +      Mesa repository
> > 
> > I would add "as it clutters it unnecessarily" as you mentioned in the
> > commit message.
> 
> I was considering this, but decided against it as the other things in
> this list didn't really specify motivation either. But I think you're
> right, it's better to include it in this case.
> 
> Fixed locally (but I added a comma first, which I *think* is correct?):

It *is* correct :)
r-b

> 
> diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> index 736cbd64de8..137e39c925d 100644
> --- a/docs/submittingpatches.html
> +++ b/docs/submittingpatches.html
> @@ -258,6 +258,8 @@ your email administrator for this.)
>        rebased
>      <li>Make sure your MR is closed if your patches get pushed outside
>        of GitLab
> +    <li>Please send MRs from a personal fork rather than from the main
> +      Mesa repository, as it clutters it unnecessarily.
>    </ul>
>  </p>
>  
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev