[Mesa-dev] [PATCH] mapi: print function declarations for shared glapi

Emil Velikov emil.l.velikov at gmail.com
Fri Jan 25 16:25:43 UTC 2019


From: Emil Velikov <emil.velikov at collabora.com>

Earlier commit aimed to remove unneeded function declarations. Namely
OpenGL entrypoints which are not applicable for OpenGLES*

Although it did not consider the shared glapi which needs all,
including hidden ones. Resulting in warning/errors like the following

../build/src/mapi/shared-glapi/glapi_mapi_tmp.h:26014:15:
error: no previous prototype for ‘shared_dispatch_stub_1414’ [-Werror=missing-prototypes]

This patch addressed that.

Cc: Erik Faye-Lund <erik.faye-lund at collabora.com>
Cc Eric Anholt <eric at anholt.net>
Reported-by: Eric Anholt <eric at anholt.net>
Fixes: 6148cce388f ("mapi: drop unneeded gl_dispatch_stub declarations")
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 src/mapi/mapi_abi.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mapi/mapi_abi.py b/src/mapi/mapi_abi.py
index 4293cc0c6c2..8b436638d2b 100644
--- a/src/mapi/mapi_abi.py
+++ b/src/mapi/mapi_abi.py
@@ -265,7 +265,7 @@ class ABIPrinter(object):
             if not self.need_entry_point(ent):
                 continue
             export = self.api_call if not ent.hidden else ''
-            if not ent.hidden:
+            if not ent.hidden or not self.lib_need_non_hidden_entries:
                 decls.append(self._c_decl(ent, prefix, True, export) + ';')
 
         return "\n".join(decls)
-- 
2.20.1



More information about the mesa-dev mailing list