[Mesa-dev] [PATCH] meson: Fix typo.

Eric Engestrom eric.engestrom at intel.com
Sat Jan 26 09:12:05 UTC 2019


On Saturday, 2019-01-26 00:50:40 -0800, Caio Marcelo de Oliveira Filho wrote:
> This patch is
> 
> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
> 
> Since it fixes a patch that were marked for stable, maybe add CC:
> stable for this one too?

`Fixes:` already means it will be applied everywhere the fixed commit
has been ported.
That said, duplicating the information with a `cc: stable` shouldn't
hurt :)

> 
> On Sat, Jan 26, 2019 at 08:28:20AM +0000, Vinson Lee wrote:
> > meson.build:166:21: ERROR:  Unknown method "verson_compare" for a string.
> > 
> > Fixes: c1efa240c91e ("meson: Add warnings and errors when using ICC")
> > Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> > ---
> >  meson.build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 2d730708d067..287d9e0eed2b 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -163,9 +163,9 @@ with_gallium_virgl = _drivers.contains('virgl')
> >  with_gallium_swr = _drivers.contains('swr')
> >  
> >  if cc.get_id() == 'intel'
> > -  if meson.version().verson_compare('< 0.49.0')
> > +  if meson.version().version_compare('< 0.49.0')
> >      error('Meson does not have sufficient support of ICC before 0.49.0 to compile mesa')
> > -  elif with_gallium_swr and meson.version().verson_compare('== 0.49.0')
> > +  elif with_gallium_swr and meson.version().version_compare('== 0.49.0')
> >      warning('Meson as of 0.49.0 is sufficient for compiling mesa with ICC, but there are some caveats with SWR. 0.49.1 should resolve all of these')
> >    endif
> >  endif
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> 	Caio
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list