[Mesa-dev] [Review Request (master branch)] st/mesa: Fix topogun-1.06-orc-84k-resize.trace crash
Brian Paul
brianp at vmware.com
Tue Jan 29 18:54:48 UTC 2019
On 01/29/2019 11:34 AM, Neha Bhende wrote:
> This patch fixes regression caused by
> bac8534267- st/mesa: allow glDrawElements to work with GL_SELECT feedback
> We also need to set instance count while creating new rastpos stage.
I forgot to previously mention, you should have a line like this in the
commit msg:
Fixes: bac8534267 ("st/mesa: allow glDrawElements to work with GL_SELECT
feedback")
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
> ---
> src/mesa/state_tracker/st_cb_rasterpos.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/state_tracker/st_cb_rasterpos.c b/src/mesa/state_tracker/st_cb_rasterpos.c
> index fecaaf7..cca2fba 100644
> --- a/src/mesa/state_tracker/st_cb_rasterpos.c
> +++ b/src/mesa/state_tracker/st_cb_rasterpos.c
> @@ -206,6 +206,7 @@ new_draw_rastpos_stage(struct gl_context *ctx, struct draw_context *draw)
> rs->prim.indexed = 0;
> rs->prim.begin = 1;
> rs->prim.end = 1;
> + rs->prim.num_instances = 1;
> rs->prim.start = 0;
> rs->prim.count = 1;
>
>
More information about the mesa-dev
mailing list