[Mesa-dev] [PATCH 16/19] radv: execute external subpass barriers after ending subpasses

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Jan 29 21:19:01 UTC 2019


Outgoing dependencies (ie. external) should happen after the subpass.
This doesn't change anything for subpass resolves as we already
make sure that attachments are shader readable.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index e7ae7b37efb..93982c1232e 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -4356,10 +4356,10 @@ void radv_CmdEndRenderPass(
 {
 	RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer);
 
-	radv_subpass_barrier(cmd_buffer, &cmd_buffer->state.pass->end_barrier);
-
 	radv_cmd_buffer_end_subpass(cmd_buffer);
 
+	radv_subpass_barrier(cmd_buffer, &cmd_buffer->state.pass->end_barrier);
+
 	vk_free(&cmd_buffer->pool->alloc, cmd_buffer->state.attachments);
 
 	cmd_buffer->state.pass = NULL;
-- 
2.20.1



More information about the mesa-dev mailing list