[Mesa-dev] [Review Request (master branch)] st/mesa: Fix topogun-1.06-orc-84k-resize.trace crash

[Neha Bhende]

Thanks Brian and Ilia for the review.


Regards,

Neha

________________________________
From: Ilia Mirkin <imirkin at alum.mit.edu>
Sent: Tuesday, January 29, 2019 1:20:50 PM
To: Brian Paul
Cc: Neha Bhende; mesa-dev at lists.freedesktop.org
Subject: Re: [Review Request (master branch)] st/mesa: Fix topogun-1.06-orc-84k-resize.trace crash

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Note - not sure that initializing pad is necessary. And there's a
handful of fields missing (like the draw id comes to mind). But ...
it's not important. Sorry again for the screwup!

On Tue, Jan 29, 2019 at 4:17 PM Brian Paul <brianp at vmware.com> wrote:
>
> LGTM.  Reviewed-by: Brian Paul <brianp at vmware.com>
>
> I'll push this tomorrow, or after Ilia reviews too.
>
>
> On 01/29/2019 12:21 PM, Neha Bhende wrote:
> > We need to initialize all fields in rs->prim explicitly while
> > creating new rastpos stage.
> >
> > Fixes: bac8534267 ("st/mesa: allow glDrawElements to work with GL_SELECT
> > feedback")
> >
> > v2: Initializing all fields in rs->prim as per Ilia.
> >
> > Reviewed-by: Brian Paul <brianp at vmware.com>
> > ---
> >   src/mesa/state_tracker/st_cb_rasterpos.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/src/mesa/state_tracker/st_cb_rasterpos.c b/src/mesa/state_tracker/st_cb_rasterpos.c
> > index fecaaf7..c54b50d 100644
> > --- a/src/mesa/state_tracker/st_cb_rasterpos.c
> > +++ b/src/mesa/state_tracker/st_cb_rasterpos.c
> > @@ -208,6 +208,10 @@ new_draw_rastpos_stage(struct gl_context *ctx, struct draw_context *draw)
> >      rs->prim.end = 1;
> >      rs->prim.start = 0;
> >      rs->prim.count = 1;
> > +   rs->prim.pad = 0;
> > +   rs->prim.num_instances = 1;
> > +   rs->prim.base_instance = 0;
> > +   rs->prim.is_indirect = 0;
> >
> >      return rs;
> >   }
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190130/c49be09e/attachment-0001.html>