[Mesa-dev] [PATCH 00/13] Enable fp16 visuals and fbconfigs

[Strasser, Kevin]

Adam Jackson wrote:
> On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote:
> > This series enables fp16 fbconfigs and visuals by leveraging existing 
> > off-screen rendering support.
> > 
> > These formats can be used in conjunction with 
> > EXT_surface_SMPTE2086_metadata (not yet implemented by any drivers) to 
> > support EXT_gl_colorspace_scrgb / EXT_gl_colorspace_scrgb_linear, used 
> > in places like Android wide color gamut.
> 
> This looks great! Comments on 4/ and 11/ are minor, and haven't built my way through testing this yet, but:
> 
> Reviewed-by: Adam Jackson <ajax at redhat.com>

Thanks for the review!

I forgot to mention, the following dEQP cases should Pass on Wayland with the
series applied:
  dEQP-EGL.functional.wide_color.fp16
  dEQP-EGL.functional.wide_color.window_fp16_default_colorspace

and the following cases are expected to remain NotSupported:
  dEQP-EGL.functional.wide_color.window_fp16_colorspace_srgb
  dEQP-EGL.functional.wide_color.window_fp16_colorspace_p3
  dEQP-EGL.functional.wide_color.window_fp16_colorspace_scrgb
  dEQP-EGL.functional.wide_color.window_fp16_colorspace_scrgb_linear

Thanks,
Kevin