[Mesa-dev] [PATCH 0/2] Initial Panfrost driver

[Emil Velikov]

Hi Alyssa,

On Wed, 30 Jan 2019 at 05:43, Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:
>
> Panfrost is a community-led, free software driver for Mali Midgard and
> Bifrost GPUs. This patchset contains the initial changes for upstreaming
> the driver. On the command stream side, for now only a stub and winsys
> integration is included; the full driver is pending on kernel changes.
> As for shaders, the complete Midgard toolchain is included (assembler,
> disassembler, compiler), which provides immediate utility via the
> standalone interface.
>
> Panfrost is _not_ ready for general use yet; please do not misinterpret
> this upstreaming as anything more than what's necessary to ease
> rebasing. These patches **do not include the actual command stream
> driver**, accounting for several thousand lines of code, which as always
> can be found at https://gitlab.freedesktop.org/panfrost/mesa. As our
> kernel driver matures, this code will be submitted as well.
>
> Alyssa Rosenzweig (2):
>   panfrost: Initial stub for Panfrost driver
>   panfrost: Implement Midgard shader toolchain
>
I've had a quick skim through and overall it looks quite nice.

As you pointed out, the CS of the driver is not included, so I wonder
if we cannot add link to instructions in panfrost_create_screen()
Reading the current fprintf is fairly discouraging.

fprintf(stderr, "stub: Upstream panfrost (use downstream fork)\n");

Either way the series is:
Acked-by: Emil Velikov <emil.velikov at collabora.com>

-Emil