[Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

Alyssa Rosenzweig alyssa at rosenzweig.io
Thu Jan 31 16:26:29 UTC 2019


> There's u_pipe_screen_get_param_defaults() that you really want to be
> using to avoid regressions when people add new pipe caps.  You can get
> rid of a lot of your switch statement that way, too.

Oh, good to know. Is that newer? I'm pretty sure that whole block was
copied from vc4 at some point ;)

> We should probably be sticking the kmsro entrypoints in a shared group,
> since there's nothing specific for the KMS .  Looks like we haven't been
> doing that, though.

Yeah, I had the same thought, but I didn't want to disrupt other drivers
yet (since that delays merge due to pinging more people).

> These are both things we can change later.  I'm mostly excited to see
> you finally in-tree!

^_^

Should either of the above issues be resolved in a v2 now, or just a
follow-up patch after merging?




More information about the mesa-dev mailing list