[Mesa-dev] [PATCH] panfrost: Add the sampled texture BO to the job

Boris Brezillon boris.brezillon at collabora.com
Mon Jul 1 15:29:56 UTC 2019


On Mon, 1 Jul 2019 08:28:03 -0700
Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:

> >  
> > @@ -848,6 +850,7 @@ panfrost_upload_tex(
> >          for (unsigned l = first_level; l <= last_level; ++l) {
> >                  for (unsigned f = first_layer; f <= last_layer; ++f) {
> >  
> > +                        panfrost_job_add_bo(job, rsrc->bo);
> >                          view->hw.payload[idx++] =
> >                                  panfrost_get_texture_address(rsrc, l, f) + afbc_bit;  
> 
> The bo is guaranteed to be the same for all levels and layers. So this
> should be pulled out of both loops.

Absolutely, guess I was to prompt at sending the patch.


More information about the mesa-dev mailing list