[Mesa-dev] [PATCH v2] panfrost: Add the sampled texture BO to the job

[Alyssa Rosenzweig]

R-b, thank you! :)

On Mon, Jul 01, 2019 at 07:04:44PM +0200, Boris Brezillon wrote:
> Otherwise we get random use-after-{free,unmap} errors.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> ---
> Changes in v2:
> - Move the panfrost_job_add_bo() call out of the loop
> ---
>  src/gallium/drivers/panfrost/pan_context.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
> index bf98d3853f16..c103a764edd9 100644
> --- a/src/gallium/drivers/panfrost/pan_context.c
> +++ b/src/gallium/drivers/panfrost/pan_context.c
> @@ -840,6 +840,10 @@ panfrost_upload_tex(
>          bool is_zs = rsrc->base.bind & PIPE_BIND_DEPTH_STENCIL;
>          unsigned afbc_bit = (is_afbc && !is_zs) ? 1 : 0;
>  
> +	/* Add the BO to the job so it's retained until the job is done. */
> +        struct panfrost_job *job = panfrost_get_job_for_fbo(ctx);
> +        panfrost_job_add_bo(job, rsrc->bo);
> +
>          /* Inject the addresses in, interleaving mip levels, cube faces, and
>           * strides in that order */
>  
> -- 
> 2.21.0
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190701/86498863/attachment.sig>