[Mesa-dev] radeonsi: glmark2 - regression (GL_INVALID_OPERATION in glFramebufferTexture2D) - bisected

[Dieter Nützel]

Hello Emil et al.,

sorry Emil you were NOT the right person to blame for this - see below.

Am 22.06.2019 04:55, schrieb Dieter Nützel:
> Hello Emil,
> 
> I see glmark2 - [desktop] blur-radius=5
> 
> libpng warning: iCCP: known incorrect sRGB profile
> Mesa: User error: GL_INVALID_OPERATION in
> glFramebufferTexture2D(window-system framebuffer)
> [desktop] blur-radius=5:effect=blur:passes=1:separable=true:windows=4:
> FPS: 4879 FrameTime: 0.205 ms
> 
> after your commits around beginning of June (2019-06-05) or your
> 'mapi'-work commited around 2019-06-10.

I had to go much further back...

> Have to bisect.

Did it, now. Hello Marek and Mathias ;-)

/opt/mesa> git bisect good
b5697c311b6f29dee40b96c48bad3279e3667c1e is the first bad commit
commit b5697c311b6f29dee40b96c48bad3279e3667c1e
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Thu May 9 21:04:23 2019 -0400

     Change a few frequented uses of DEBUG to !NDEBUG

     debugoptimized builds don't define NDEBUG, but they also don't 
define
     DEBUG. We want to enable cheap debug code for these builds.
     I only chose those occurences that I care about.

     Reviewed-by: Mathias Fröhlich <Mathias.Froehlich at web.de>

  src/gallium/auxiliary/tgsi/tgsi_ureg.c              | 2 +-
  src/gallium/drivers/radeonsi/si_descriptors.c       | 2 +-
  src/gallium/drivers/radeonsi/si_pipe.h              | 2 +-
  src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6 +++---
  src/gallium/drivers/radeonsi/si_state.c             | 4 ++--
  src/mesa/main/context.c                             | 2 +-
  src/mesa/main/debug.c                               | 4 ++--
  src/mesa/main/errors.c                              | 6 +++---
  src/mesa/main/feedback.c                            | 2 +-
  src/mesa/main/formats.c                             | 2 --
  src/mesa/main/imports.c                             | 4 ++--
  src/mesa/main/mtypes.h                              | 2 +-
  src/mesa/main/shaderapi.c                           | 2 +-
  src/mesa/state_tracker/st_atom_framebuffer.c        | 2 +-
  src/mesa/state_tracker/st_format.c                  | 2 +-
  src/mesa/vbo/vbo_exec.h                             | 2 +-
  src/mesa/vbo/vbo_exec_api.c                         | 6 +++---
  src/util/slab.c                                     | 4 ++--
  18 files changed, 27 insertions(+), 29 deletions(-)

After reverting this all is fine, again.

My meson config for Mesa git:
meson ../ --strip --buildtype debugoptimized -Ddri-drivers= 
-Dplatforms=drm,x11 -Dgallium-drivers=r600,radeonsi,swrast 
-Dvulkan-drivers=amd -Dgallium-nine=true -Dgallium-opencl=standalone 
-Dglvnd=true -Dgallium-va=false -Dgallium-xvmc=false 
-Dgallium-omx=disabled -Dgallium-xa=false

Greetings,
Dieter