[Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

[Tomeu Vizoso]

On Tue, 2 Jul 2019 at 17:02, Boris Brezillon
<boris.brezillon at collabora.com> wrote:
>
> On Tue, 2 Jul 2019 16:54:22 +0200
> Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
>
> > On Tue, 2 Jul 2019 at 15:24, Boris Brezillon
> > <boris.brezillon at collabora.com> wrote:
> > >
> > > There's no point duplicating the code, and it will help us simplify
> > > the bo_handles[] filling logic in panfrost_drm_submit_job().
> >
> > Looks good but, could we drop panfrost_memory completely? Other
> > drivers seem to do fine wthout such a thing.
>
> We need a wrapper that contains a BO plus a pb_slab object for
> SLAB-based allocations (allocation of sub-page-size objects), that's
> exactly what panfrost_memory is right now. We can rename it if you
> like, but I don't think we can get rid of it.

Sounds good, thanks!

Tomeu