[Mesa-dev] [PATCH kmscube] Search for a suitable config

Daniel Stone daniel at fooishbar.org
Wed Jul 3 07:29:17 UTC 2019


Hi Drew,

On Wed, 3 Jul 2019 at 08:16, Drew DeVault <sir at cmpwn.com> wrote:
> Instead of assuming the first will be suitable. kmscube fails to start
> for me without this change.

There are a couple of unrelated changes combined in here, but I think
the core one is good.

eglChooseConfig has some really useful properties, where it strictly
specifies a sort order, does not include EGL_NATIVE_VISUAL_ID in that
sort order, and silently accepts attributes which are not relevant for
the sort. Your change which takes all possible configs and then
queries them to make sure that the native visual ID is actually
correct is the right thing to do.

Cheers,
Daniel


More information about the mesa-dev mailing list