[Mesa-dev] [PATCH] radv: fix memory leak when restoring from cache

Samuel Pitoiset samuel.pitoiset at gmail.com
Wed Jul 10 07:04:26 UTC 2019


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 7/10/19 6:11 AM, Timothy Arceri wrote:
> Fixes: 726a31df705b ("radv: Add the concept of radv shader binaries.")
> ---
>   src/amd/vulkan/radv_pipeline_cache.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c
> index 2b3fda6eb8e..b773de30c32 100644
> --- a/src/amd/vulkan/radv_pipeline_cache.c
> +++ b/src/amd/vulkan/radv_pipeline_cache.c
> @@ -309,6 +309,7 @@ radv_create_shader_variants_from_pipeline_cache(struct radv_device *device,
>   			p += entry->binary_sizes[i];
>   
>   			entry->variants[i] = radv_shader_variant_create(device, binary);
> +			free(binary);
>   		} else if (entry->binary_sizes[i]) {
>   			p += entry->binary_sizes[i];
>   		}


More information about the mesa-dev mailing list