[Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Wed Jul 10 14:15:17 UTC 2019

> I don't think other drivers have had to do this. I've definitely
> resisted stuff like that in nouveau in the past. Are you sure this is
> necessary? Would be good to check if these tests pass or fail on
> nouveau, for example. (Although by coincidence, they could be ending
> up with zero values, of course...)

It's not necessary, no, but... \shrug/

It is a good idea for us, at least; otherwise the undef will get a
register allocated for it and then not uninitialize the register and
we'll read back pseudorandom garbage. Rewriting to zero is legal and
ensures that sort of impossible-to-debug bug never pops up, even if it's
a dumb corner case.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190710/9a8175af/attachment.sig>

More information about the mesa-dev mailing list