[Mesa-dev] [PATCH 3/3] android: amd/addrlib: add gfx10 support

[Mauro Rossi]

Hi again Mark,

On Wed, Jul 10, 2019 at 4:59 PM Mark Janes <mark.a.janes at intel.com> wrote:

> Do you have some documentation on how you are building Android with
> Mesa?  We set up a buildtest using an Android (Celadon) tree from Intel,
> and it seems to be less up-to-date than your build.
>
> Last week, you found a build error that was missed by our CI.  When you
> pushed this series, we got:
>
>  src/egl/main/egldevice.c:126:11: error: implicit declaration of function
> 'drmDevicesEqual'
>

This function should be provided by libdrm (mesa/drm xf86drm.h)
because the code is between  #ifdef HAVE_LIBDRM/#endif braces.

I'm using the following libdrm branch, but android-x86 additional commits
and my last one to prevent building error in IA-HardwareComposer,
shouldn't be neither interfering nor helping:
https://github.com/maurossi/drm/commits/2.4.99_android-x86

My series of fixes on amdgpu/radeonsi Android build rules did not touch
src/egl build rules
and looking at Chih-Wei they seem also unrelated, he may confirm that

Mauro



>
> I'd like to leverage your work to improve our automation, so we don't
> break your tree again.
>
> -Mark
>
> Mauro Rossi <issor.oruam at gmail.com> writes:
>
> > Fix the following building error:
> >
> > external/mesa/src/amd/addrlib/src/gfx10/gfx10addrlib.cpp:35:10:
> > fatal error: 'gfx10_gb_reg.h' file not found
> >          ^~~~~~~~~~~~~~~~
> > 1 error generated.
> >
> > Fixes: 78cdf9a ("amd/addrlib: add gfx10 support")
> > Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
> > ---
> >  src/amd/Android.addrlib.mk | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/amd/Android.addrlib.mk b/src/amd/Android.addrlib.mk
> > index 428fe19b20..eec78fc8bf 100644
> > --- a/src/amd/Android.addrlib.mk
> > +++ b/src/amd/Android.addrlib.mk
> > @@ -37,6 +37,7 @@ LOCAL_C_INCLUDES := \
> >       $(MESA_TOP)/src/amd/addrlib/src \
> >       $(MESA_TOP)/src/amd/addrlib/src/core \
> >       $(MESA_TOP)/src/amd/addrlib/src/chip/gfx9 \
> > +     $(MESA_TOP)/src/amd/addrlib/src/chip/gfx10 \
> >       $(MESA_TOP)/src/amd/addrlib/src/chip/r800
> >
> >  LOCAL_EXPORT_C_INCLUDE_DIRS := \
> > --
> > 2.20.1
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190710/852cba06/attachment.html>