[Mesa-dev] [PATCH] radv/gfx10: fix maximum number of mip levels for 3D images

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Jul 11 12:27:53 UTC 2019


r-b

On Thu, Jul 11, 2019 at 2:24 PM Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
> The dimensions also have to be adjusted if the number of supported
> mip levels is changed.
>
> This fixes dEQP-VK.api.info.image_format_properties.3d.*.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_formats.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
> index 26fc4b9ba18..98c84edbdc1 100644
> --- a/src/amd/vulkan/radv_formats.c
> +++ b/src/amd/vulkan/radv_formats.c
> @@ -1150,10 +1150,16 @@ static VkResult radv_get_image_format_properties(struct radv_physical_device *ph
>                 maxArraySize = chip_class >= GFX10 ? 8192 : 2048;
>                 break;
>         case VK_IMAGE_TYPE_3D:
> -               maxExtent.width = 2048;
> -               maxExtent.height = 2048;
> -               maxExtent.depth = 2048;
> -               maxMipLevels = chip_class >= GFX10 ? 14 : 12; /* log2(maxWidth) + 1 */
> +               if (chip_class >= GFX10) {
> +                       maxExtent.width = 8192;
> +                       maxExtent.height = 8192;
> +                       maxExtent.depth = 8192;
> +               } else {
> +                       maxExtent.width = 2048;
> +                       maxExtent.height = 2048;
> +                       maxExtent.depth = 2048;
> +               }
> +               maxMipLevels = util_logbase2(maxExtent.width) + 1;
>                 maxArraySize = 1;
>                 break;
>         }
> --
> 2.22.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list