[Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

Eric Anholt eric at anholt.net
Fri Jul 12 00:09:25 UTC 2019


Jason Ekstrand <jason at jlekstrand.net> writes:

> On Tue, Jul 9, 2019 at 11:19 AM Kristian Høgsberg <hoegsberg at gmail.com>
> wrote:
>
>> On Tue, Jul 9, 2019 at 12:17 AM Daniel Stone <daniel at fooishbar.org> wrote:
>> >
>> > Hi,
>> >
>> > On Sat, 6 Jul 2019 at 18:39, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> > > I see this as driving away contributions, esp from new people. MR's
>> > > are annoying to create, since they require dealing with the hosting
>> > > provider, getting it to host clones, etc. Everyone has email.
>> >
>> > My position - and the evidence of velocity from projects who have
>> > switched - is already pretty clear, but you might be interested to
>> > read that even kernel.org admins are trying to move away from email:
>> >
>> https://people.kernel.org/monsieuricon/patches-carved-into-developer-sigchains
>>
>> I have the same experience - I've used git since before it was usable
>> and I'm more than happy to not have to worry about making git
>> send-email work. I'm pretty sure that gitlab in general lowers the bar
>> for contributions considerably, I know I find my self doing a lot more
>> reviews and drive-by comments because of how easy it feels
>
>
> I know I'm a gitlab fan-boy so you all know I like this.  What I will say
> is that it's not only easier for new developers because PRs are a concept
> they already know from GitHub and the like but it's also easier for
> maintainers.  I've actually started getting annoyed when people send
> patches to the list and I have to apply them from e-mail.  It's so much
> easier to just check that they've added all the tags and click a couple
> buttons in the web UI than to have to find the thing on patchwork, download
> it, hope it applies, and push it.

Same.  I'm actually not reading patches on the mailing list any more.
If you want my input, put it in the system where I don't have to waste
my time tracking if it's been merged or not and whether you responded to
my comments from the last round.

I don't think we're quite to "make sure they've added the tags and click
the button" safely since we don't have pre-merge testing happening (you
have to trust that the submitter tested, and master hasn't regressed
things since then).  I'm working on that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190711/ced7fffb/attachment-0001.sig>


More information about the mesa-dev mailing list