[Mesa-dev] [PATCH] radv: put back VGT_FLUSH at ring init on gfx10

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Jul 18 06:25:08 UTC 2019


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 7/18/19 8:14 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> I can find no evidence that removing this is a good idea.
>
> Fixes: 9b116173b6a ("radv: do not emit VGT_FLUSH on GFX10")
> ---
>   src/amd/vulkan/radv_device.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index b397a9a8aa0..8dd24cb8192 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -2753,10 +2753,8 @@ radv_get_preamble_cs(struct radv_queue *queue,
>   			radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 0, 0));
>   			radeon_emit(cs, EVENT_TYPE(V_028A90_VS_PARTIAL_FLUSH) | EVENT_INDEX(4));
>   
> -			if (queue->device->physical_device->rad_info.chip_class < GFX10) {
> -				radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 0, 0));
> -				radeon_emit(cs, EVENT_TYPE(V_028A90_VGT_FLUSH) | EVENT_INDEX(0));
> -			}
> +			radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 0, 0));
> +			radeon_emit(cs, EVENT_TYPE(V_028A90_VGT_FLUSH) | EVENT_INDEX(0));
>   		}
>   
>   		radv_emit_gs_ring_sizes(queue, cs, esgs_ring_bo, esgs_ring_size,


More information about the mesa-dev mailing list