[Mesa-dev] [PATCH] radv: reset the window scissor with no clear state.

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Jul 18 08:00:43 UTC 2019


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 7/18/19 3:20 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> IF we don't have clear state (which gfx10 doesn't currently)
> we will fix to reset the scissor. AMDVLK will leave it set
> to something else.
>
> Marek also has this fix for radeonsi pending.
> ---
>   src/amd/vulkan/si_cmd_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index 6fe447ef2e9..0efa169d674 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -202,7 +202,7 @@ si_emit_graphics(struct radv_physical_device *physical_device,
>   	/* CLEAR_STATE doesn't clear these correctly on certain generations.
>   	 * I don't know why. Deduced by trial and error.
>   	 */
> -	if (physical_device->rad_info.chip_class <= GFX7) {
> +	if (physical_device->rad_info.chip_class <= GFX7 || !physical_device->has_clear_state) {
>   		radeon_set_context_reg(cs, R_028B28_VGT_STRMOUT_DRAW_OPAQUE_OFFSET, 0);
>   		radeon_set_context_reg(cs, R_028204_PA_SC_WINDOW_SCISSOR_TL,
>   				       S_028204_WINDOW_OFFSET_DISABLE(1));


More information about the mesa-dev mailing list